Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: sync store config in time (#6919) #6931

Merged
merged 8 commits into from
Sep 14, 2024
Merged

config: sync store config in time (#6919) #6931

merged 8 commits into from
Sep 14, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6919

What problem does this PR solve?

Issue Number: Close #6918

What is changed and how does it work?

add timeout context for observer tikv config to avoid wait too long

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

sync store config in time

@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#6919
62a8529 
close tikv#6918

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 10, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Aug 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx August 10, 2023 05:34
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
@bufferflies
resolve conflict
b7c40c7 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2023
@bufferflies
resolve conflict
ea3eb3a 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
Merge branch 'cherry-pick-6919-to-release-6.1' of github.com:ti-chi-b…
b92aa89 
…ot/pd into cherry-pick-6919-to-release-6.1
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.44%. Comparing base (a2f526d) to head (be8d521).
Report is 7 commits behind head on release-6.1.

Files with missing lines Patch % Lines
server/config/store_config.go 50.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-6.1    #6931      +/-   ##
===============================================
- Coverage        75.51%   75.44%   -0.08%     
===============================================
  Files              308      308              
  Lines            30604    30619      +15     
===============================================
- Hits             23111    23100      -11     
- Misses            5492     5510      +18     
- Partials          2001     2009       +8
Flag Coverage Δ
unittests 75.44% <76.19%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ti-chi-bot bot pushed a commit that referenced this pull request Aug 11, 2023
@bufferflies
config: sync store config in time (#6919) #6931 (#6952)
a5c8b89 
close #6918

add timeout context for observer tikv config to avoid wait too long

Signed-off-by: bufferflies <1045931706@qq.com>
@AndreMouche
Copy link
Member

/LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2024
@AndreMouche AndreMouche mentioned this pull request Mar 21, 2024
Closed
3 tasks
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 13, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 13, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-13 07:33:32.018084016 +0000 UTC m=+600881.758507947: ☑️ agreed by rleungx.
  • 2024-09-13 07:37:22.673784359 +0000 UTC m=+601112.414208298: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Sep 13, 2024
@ti-chi-bot ti-chi-bot bot removed the approved label Sep 14, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreMouche, HuSharp, lhy1024, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit ec9f2c3 into tikv:release-6.1 Sep 14, 2024
18 checks passed
@HuSharp HuSharp deleted the cherry-pick-6919-to-release-6.1 branch September 14, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@niubell niubell niubell approved these changes

@AndreMouche AndreMouche AndreMouche approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees

@bufferflies bufferflies

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-chi-bot @AndreMouche @niubell @lhy1024 @rleungx @HuSharp @bufferflies